https://bugzilla.wikimedia.org/show_bug.cgi?id=25580

--- Comment #6 from Dmitriy <c...@uniyar.ac.ru> 2010-10-25 05:46:17 UTC ---
Roan, it seems that ResourceLoader bug is quite simple, too. My 1.17 testing
site uses Monobook skin, not Vector. and in 
ResourceLoaderFileModule::getModifiedTime() there is a following line:

        $filesMtime = max( array_map( 'filemtime', array_map( array( __CLASS__,
'remapFilename' ), $files ) ) );

which produced a warning with bad consequences, because $files[] elements might
be Array, not just strings:

$files=array(1) {
  [0]=>
  string(23) "skins/vector/screen.css"
}

$files=array(1) {
  [0]=>
  string(28) "skins/common/commonPrint.css"
}

$files=array(1) {
  [0]=>
  string(23) "skins/common/shared.css"
}

$files=array(2) {
  [0]=>
  string(23) "skins/monobook/main.css"
  [1]=>
  array(1) {
    ["media"]=>
    string(8) "handheld"
  }
} 


note that in last case resourceloadermodule $files[1] is array which indicates
media type of stylesheet. One should not do direct array_map() on such arrays
to expect valid string result. "Array" string is produced and of course it is
not a valid file name so one could not filemtime() it.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to