https://bugzilla.wikimedia.org/show_bug.cgi?id=25580

--- Comment #8 from Dmitriy <c...@uniyar.ac.ru> 2010-11-09 18:51:39 UTC ---
Yes, ResourceLoader issue has disappeared. However, SpecialImport issue is
still here:
[09-Nov-2010 20:43:13] PHP Warning:  Missing argument 5 for
WikiImporter::finishImportPage() in C:\www\phase3\includes\ImportXMLReader.php
on line 182

[09-Nov-2010 20:43:13] PHP Warning:  Missing argument 5 for
WikiImporter::finishImportPage() in C:\www\phase3\includes\ImportXMLReader.php
on line 182

[09-Nov-2010 20:43:13] PHP Warning:  Missing argument 5 for
WikiImporter::finishImportPage() in C:\www\phase3\includes\ImportXMLReader.php
on line 182

[09-Nov-2010 20:43:14] PHP Warning:  Missing argument 5 for
WikiImporter::finishImportPage() in C:\www\phase3\includes\ImportXMLReader.php
on line 182

[09-Nov-2010 20:43:15] PHP Warning:  Missing argument 5 for
WikiImporter::finishImportPage() in C:\www\phase3\includes\ImportXMLReader.php
on line 182

[09-Nov-2010 20:43:15] PHP Warning:  Missing argument 5 for
WikiImporter::finishImportPage() in C:\www\phase3\includes\ImportXMLReader.php
on line 182

Besides ImportReporter, also ApiImportReporter uses only four parameters while
WikiImporter::finishImportPage() expects five parameters and not providing the
default value for 5th parameter.

Sounds like this bug is very easy to fix. The question is, what is better - to
provide the default value of 5th parameter in WikiImporter::finishImportPage(),
or to modify calls to provide proper value of $pageInfo in ImportReporter and
ApiImportReporter.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to