https://bugzilla.wikimedia.org/show_bug.cgi?id=24650

--- Comment #4 from Reedy <s...@reedyboy.net> 2011-01-14 21:34:24 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > So we're missing the index as we're not sorting on cl_type
> > 
> Besides sorting we should also actually be doing stuff with cl_type
> (outputting, filtering).

r80324 allows cl_type to be shown and allows filtering on cl_type

> 
> > We're using cl_sortkey as a continue. That probably needs changing.
> > 
> Yes, needs to be some compound key that forms a unique index.

That's the next job... See what I can come up with.

> 
> > ApiQueryCategories:
> > 
> > Output of sortkey is probably pointless now...?
> Let's keep it around for back compat. It's also not totally useless (useful 
> for
> e.g. debugging collations and the like).

(In reply to comment #3)
> >> Output of sortkey is probably pointless now...?
> >Let's keep it around for back compat. It's also not totally useless (useful 
> >for
> >e.g. debugging collations and the like).
> 
> How about anywhere a sortkey is displayed in the api, we now have two fields,
> sortkey would be the human readable sortkey based cl_sortkey_prefix (on the
> assumption that most people using the api for sortkeys currently use it to
> display to user, not to sort things), and then another field, rawsortkey that
> has the binary sortkey in it.
> 
> Does that sound like the right course of action?

That seems sane. Hopefully people aren't doing anything, but we have no idea.

Keeping the names more like the cols is probably a better idea

Roan, what do you think about what Bawolff suggested?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to