Roan Kattouw <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #1 from Roan Kattouw <> 2011-03-04 10:38:02 
UTC ---
(In reply to comment #0)
> patch attached.
* Don't use empty()
* Don't use + to merge arrays with numerical indices, it doesn't do what you
think it does. In this case, it causes the job_id >= $offset condition to be
overwritten with the first element of $conditions. Use array_merge() instead
* $wgJobExplitRequestTypes is misspelled, should be $wgJobExplicitRequestTypes.
I'm also not a big fan of that name, but then I can't think of anything better

Looks good otherwise.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

Wikibugs-l mailing list

Reply via email to