https://bugzilla.wikimedia.org/show_bug.cgi?id=27336

Roan Kattouw <roan.katt...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roan.katt...@gmail.com

--- Comment #1 from Roan Kattouw <roan.katt...@gmail.com> 2011-03-04 10:38:02 
UTC ---
(In reply to comment #0)
> patch attached.
* Don't use empty()
* Don't use + to merge arrays with numerical indices, it doesn't do what you
think it does. In this case, it causes the job_id >= $offset condition to be
overwritten with the first element of $conditions. Use array_merge() instead
* $wgJobExplitRequestTypes is misspelled, should be $wgJobExplicitRequestTypes.
I'm also not a big fan of that name, but then I can't think of anything better
either

Looks good otherwise.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to