https://bugzilla.wikimedia.org/show_bug.cgi?id=26786
--- Comment #20 from [email protected] 2011-05-05 10:19:19 UTC --- I'd pick citation style, and document it as such. I only mentioned the other option as a way for the template to still work despite what you might more properly regard as a technical error. But graceful failure is certainly not a requirement, and I agree it can add complexity. Another thought: in theory, the first parameter could be any kind of directive that tells the function what kind of citation to render. Parameters like "journal," "book," etc. are not necessary because the function should be able to infer that from the combination of options like Citation/core does. The most meaningful first parameter is one that tells the function something that it doesn't already know. Also, in Citation/core, editors have been gradually adding various options as parameters, like directives on whether to use periods of commas, or whether or not to italicize or bold. If the first parameter is a standard citation style, all these options are unnecessary, and editors will not continually be bugging the developers to add an option for bolding here, or optional brackets there. @Svip, I don't want to back-seat drive on your excellent work, because I know how annoying that is. But I notice you added a new "getCitationStyle" function, set up so that you read the arguments twice, and note that this is inefficient and there should be a better way to do this. I had solved this problem in the working demo patch I submitted, in which the parameters were each only read once. The first parameter was read (and localized) and split off from the remaining parameters, which were passed to the constructor of the appropriate child class of TemplateAdventureBasic. If there is anything I can do to help, like put together a working CitationChicago or CitationAPA, just send me an email. And again, bravo for doing this much needed work. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
