https://bugzilla.wikimedia.org/show_bug.cgi?id=30803
--- Comment #3 from Brion Vibber <[email protected]> 2011-09-08 23:11:23 UTC --- Avoid modifying the given params map directly; the caller might be expecting to reuse it on multiple calls etc. Looks like the code makes the page parameter optional, but only params is marked as such -- probably should list [page] in the doc comments too. If allowing parameters such as other actions, $wgActionPaths may apply to canonical URL generation, which would not be picked up by the current code. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
