https://bugzilla.wikimedia.org/show_bug.cgi?id=30046

Daniel Friesen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mediawiki-bugs@nadir-seen-f
                   |                            |ire.com

--- Comment #1 from Daniel Friesen <[email protected]> 
2011-10-12 05:26:39 UTC ---
This functionality is actually not as easy as you describe it. That code change
you describe does not take into account that the addToSidebar line is in the
middle of caching code. If the sidebar cache is enabled, you can actually end
up with a logged out sidebar showing to logged in users, or a logged in sidebar
showing to logged out users, because that's what happens to be in the cache.

I've been considering this in my skin rewrite plans. However I still haven't
been shown an example where having two sidebar versions is a valid case, that
isn't actually part of a hack to work around something that should actually be
fixed instead of adding this hack.

Tbh, I almost want to WONTFIX this until someone actually gives a valid example
of why one would want two separate sidebars.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to