https://bugzilla.wikimedia.org/show_bug.cgi?id=30046

--- Comment #3 from Paolo Benvenuto <[email protected]> 2011-10-12 07:21:19 
UTC ---
CORRECTING MY PREVIOUS COMMENT.

I hadn't understood clearly, you were referring to sidebar caching, while I
meant article caching.

I think things can be done at least in the case when $wgEnableSidebarCache
isn't set, with the code:

if ($wgEnableSidebarCache || $wgUser->isLoggedIn() && $wgTwoSidebars)
$this->addToSidebar( $bar, 'sidebar' );
else $this->addToSidebar( $bar, $wgAlternateSidebar );

This code treats 'sidebar' (default) as the sidebar for logged in user; perhaps
it's better to consider default sidebar that for not logged in user and
$wgLoggedInSidebarName the sidebar name for logged in users.

This way the code would become:

if (! $wgUser->isLoggedIn() || $wgEnableSidebarCache || ! $wgTwoSidebars)
$this->addToSidebar( $bar, 'sidebar' );
else $this->addToSidebar( $bar, $wgLoggedInSidebarName );

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to