https://bugzilla.wikimedia.org/show_bug.cgi?id=31829
--- Comment #2 from Van de Bugger <[email protected]> 2011-10-19 21:34:29 UTC --- Hmmm... I said the function is inspired by `{{ #ask: … | format=count }}'. Why `ask' is intended for counting but `#subpages' is not? I see some advantages of format `count': 1. It utilizes similarity with the function `#ask': both functions recognize `intro', `outro', `default', `format' parameters. 2. No need on one more class => file, couple of hooks, etc. Regarding the db query… There is a comment in the code: // TODO: Can `getSubPages' be optimized for format `count'?" I think one more `if' in `getSubPages' is better than duplicating much of the infrastructure, including content of `getSubPages'. However, I will not insist on this approach. You are the master, you decide. > You have commit access right? Not yet. I requested it and received an answer, but something does not work. I need some time to get it really working. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
