https://bugzilla.wikimedia.org/show_bug.cgi?id=31829

--- Comment #8 from Van de Bugger <[email protected]> 2011-10-21 20:46:12 
UTC ---
> estimateRowCount is not accurate,
> The code you copied with COUNT(*) is the way to go,

?? Do not understand. The code I copied *is* the code of `estimateRowCount'
from class `Database'.

> I think having a method param that switched the db code is very
odd.

I wrote in the comments that it is not a production code. I added it just to
see the difference between different implementations. Of course parameter
should be removed, and only one implementation should remain.

So, you think code

$res = $dbr->select( 'page', 'COUNT(*) AS rowcount', $conds, __METHOD__ );

will work everywhere? I will drop other variants then.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to