matthiasmullie added a comment.

The caption was not displayed on that screenshot since it's currently implemented as optional - that's how the description widget already worked.
I've just changed it now so it always show an input, even if not required - empty input will just be ignored.

Few more things we need to figure out:

  • Caption length, how it'll work and what it'll look like
  • Caption required or optional? (and, like descriptions, can campaigns change this?)
    • Description field right now counts characters (not bytes) and needs to be within 5 & 10000 (I assume we want a different number for captions). There is no countdown or indicator you're getting close, but as soon as you hit the limit, an error message will be displayed just below input field (and it's a hard limit: it's not possible to submit once the length is exceeded - that would be easy to change to a "warning", though)
  • Error handling: if captions (or one of them) fail to submit, do we proceed without, or attempt to roll back everything?

TASK DETAIL
https://phabricator.wikimedia.org/T188502

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Base, Cparle, Ramsey-WMF, PDrouin-WMF, gerritbot, matthiasmullie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, E1presidente, Darkminds3113, Sksvdbvd, SandraF_WMF, Youssefalli1, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, PKM, aude, Bawolff, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to