| Anomie added a comment. |
In T191537#4267131, @hashar wrote:So I think the POST /index.php/Special:UserLogin completes properly and then a job is processed. That happens to be a cirrusSearchLinksUpdatePrioritized that got enqueued by a previous request/test, it then mess up with the session on the server side and the user ends up logged out.
That's what I think too.
If PHP had a send_headers() function, the fix might be as simple as calling that near the start of MediaWiki::doPostOutputShutdown() or MediaWiki::triggerSyncJobs() so cookies from jobs can't override the real request. I suppose we could do mostly the same thing by adding a static flag to WebResponse disabling WebResponse::setCookie().
Or we might be able to fix the tests by setting $wgRunJobsAsync = true, although the underlying problem would still be there for anyone with that setting off.
Cc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, Darkdadaah, scfc, Mbch331, Jay8g, greg
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
