| JeroenDeDauw added a comment. |
I don’t see the benefit of removing the entity ID from the statement GUID.
Having it in there creates a bunch of problems:
- Entities that do not have an ID yet can have statements. This forces us to have nullable GUIDs
- Statements can exist loose from Entities. For instance the Statements in a Diff between two Entities do not belong to a single Entity. Hence there is no sensible Entity id to be use here
At least one place where we need to get the entity ID from the statement ID is WikibaseQualityConstraints: in the wbcheckconstraints API, you can ask for all constraint violations of a statement, but for that we still need to load the full entity to which that statement belongs.
Why does the whole entity need to be loaded? The requested violations are stored elsewhere no? Why would you need anything beyond the GUID of the Statement?
TASK DETAIL
EMAIL PREFERENCES
To: JeroenDeDauw
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, JeroenDeDauw, Pablo-WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, JeroenDeDauw, Pablo-WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
