| JeroenDeDauw added a comment. |
AFAIK Wikibase does not use Geo 4.x, since Geo 4.x requires PHP 7.1. So it is not clear to me how the 4.1 release could affect Wikibase.
It is also not clear this issue is related to "GlobeCoordinateValue no longer extends DataValueObject". The code in the serialization thing throwing the exception checks for the interface, which is still implemented, see https://github.com/DataValues/Serialization/blob/master/src/Deserializers/DataValueDeserializer.php#L52-L63
As to "GlobeCoordinateValue no longer extends DataValueObject" technically being a breaking change, this is true. However since I am not aware of any users relying on that, especially users already on 4.x, I choose to not do a more costly (for the consumers) major release.
TASK DETAIL
EMAIL PREFERENCES
To: JeroenDeDauw
Cc: Addshore, JeroenDeDauw, Aklapper, Mvolz, Nandana, Lahi, jgleeson, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb
Cc: Addshore, JeroenDeDauw, Aklapper, Mvolz, Nandana, Lahi, jgleeson, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
