| Mvolz added a comment. |
I've done a completely fresh install (new clone and everything) and I'm producing the same issue with the wikidata role. On the client page it's the same as T197868
( ! ) Fatal error: Uncaught Error: Class 'Wikibase\DataModel\Entity\ItemId' not found in /vagrant/mediawiki/extensions/Wikibase/lib/WikibaseLib.entitytypes.php on line 35 ( ! ) Error: Class 'Wikibase\DataModel\Entity\ItemId' not found in /vagrant/mediawiki/extensions/Wikibase/lib/WikibaseLib.entitytypes.php on line 35
In T208500#4712725, @JeroenDeDauw wrote:As @Addshore said, that composer info does not look right. You'll get the error you are getting when the code is not loaded. So my guess is that you do not have it loaded.
I think that's correct.
When I do a manual composer install from WikibaseQualityConstraints, it installs lots of things. But this still doesn't fix the bug unfortunately.
My composer.lock does not include the data-values/geo library in the require, only in the require-dev, which is ~3.0. The composer.json does not point to any particular data-value/geo version. I guess this is getting pulled in as a dependency of "wikibase/data-model-serialization": "^2.0.0", which in composer.lock is 2.8.0, and that's what's present in the composer.lock, but geo isn't actually getting installed.
Here's is my composer.lock: https://phabricator.wikimedia.org/P7760. So yeah, correct that ~3 isn't installed, that's just what's included in composer.lock from having installed data-model-serialization.
I'm sort of at a loss of what to next; clearly geo is not getting installed but I can't find anything that says it *should* be since it's not in any of the composer.json files except as a dev dependency.
(Definitely there are some libraries missing, even though I've done vagrant git-update. On the wikidata page, it's still
MediaWiki internal error. Original exception: [1d92f6c895e9a708e3b01e41] /wiki/Main_Page InvalidArgumentException from line 54 of /vagrant/mediawiki/extensions/WikibaseQualityConstraints/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php: $builders must map data types to callables or class names. 'DataValues\Geo\Values\GlobeCoordinateValue' is not a DataValue class. ```) >>! In T208500#4712714, @JeroenDeDauw wrote: > AFAIK Wikibase does not use Geo 4.x, since Geo 4.x requires PHP 7.1. So it is not clear to me how the 4.1 release could affect Wikibase. > > It is also not clear this issue is related to "GlobeCoordinateValue no longer extends DataValueObject". The code in the serialization thing throwing the exception checks for the interface, which is still implemented, see https://github.com/DataValues/Serialization/blob/master/src/Deserializers/DataValueDeserializer.php#L52-L63 > > As to "GlobeCoordinateValue no longer extends DataValueObject" technically being a breaking change, this is true. However since I am not aware of any users relying on that, especially users already on 4.x, I choose to not do a more costly (for the consumers) major release. The most recent release of mediawiki is apparently not compatible with php5, support was dropped. https://www.mediawiki.org/wiki/Compatibility#PHP I'm running HEAD for everything, incl wikibase (this is what vagrant does by default).
Cc: Addshore, JeroenDeDauw, Aklapper, Mvolz, Nandana, Lahi, jgleeson, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
