| daniel added a comment. |
@aaron yea, but using CONN_TRX_AUTO in places where we want a different connection, but don't care at all about the TRX mode, is just bad. It obfuscates the code. If you read something like this for the first time, you can end up spending hours trying to understand why CONN_TRX_AUTO is relevant here - and perhaps decide it isn't, and remove it. We should really have a flag that describes the actual use case, e.g. CONN_NEW if we want to force a new connection, and CONN_AUX if all we need is "not the default" connection.
TASK DETAIL
EMAIL PREFERENCES
To: daniel
Cc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
Cc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
