| Smalyshev updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
If looking at the code makes it easier for you to grasp the idea than reading proseMigration plan:
# Transfer Cirrus-dependent code to WikibaseCirrusSearch extension, you might consider looking at https://gerrit.wikimedia.org/r/#/c/420037/ which is a very naive but fairly complete overview of what code in Wikibase would need to be moved or changed.
WMDE Engineering is fine with doing the separation workusing `Wikibase\Search\Elastic` namespace (note removed `Repo`).
# Make a switch that turns on/off all search-related hooks & configs for both extensions. Default values on for Wikibase, but due to lack of Cirrus/Elastic-related expertise, we would prefer to not be responsible for the development and maintenance of the new extensionoff for WikibaseCirrusSearch
# This is the point where we should stop accepting any patches to Cirrus code in Wikibase, as argued above.
Thoughts @SMalyshevand re-sync all patches that happened since the start with WikibaseCirrusSearch.
# After testing, @Lydia_Pintscher?flip the config above to off for Wikibase, Please feel free to add other people to the loop who you think would need to be part of this conversation.on for WikibaseCirrusSearch
# Drop the Cirrus hooks code from Wikibase
# Drop all Cirrus code from Wikibase
...
- moving code from the `Wikibase\Repo\Search\Elastic` namespace to the new extension...
- do not depend on/use FieldDefintions object in Wikibase's EntityHandlers etc. I have no immediate suggestion at hand yet, looking at this for brief two minutes I see several options to consider.If looking at the code makes it easier for you to grasp the idea than reading proseMigration plan:
# Transfer Cirrus-dependent code to WikibaseCirrusSearch extension, you might consider looking at https://gerrit.wikimedia.org/r/#/c/420037/ which is a very naive but fairly complete overview of what code in Wikibase would need to be moved or changed.
WMDE Engineering is fine with doing the separation workusing `Wikibase\Search\Elastic` namespace (note removed `Repo`).
# Make a switch that turns on/off all search-related hooks & configs for both extensions. Default values on for Wikibase, but due to lack of Cirrus/Elastic-related expertise, we would prefer to not be responsible for the development and maintenance of the new extensionoff for WikibaseCirrusSearch
# This is the point where we should stop accepting any patches to Cirrus code in Wikibase, as argued above.
Thoughts @SMalyshevand re-sync all patches that happened since the start with WikibaseCirrusSearch.
# After testing, @Lydia_Pintscher?flip the config above to off for Wikibase, Please feel free to add other people to the loop who you think would need to be part of this conversation.on for WikibaseCirrusSearch
# Drop the Cirrus hooks code from Wikibase
# Drop all Cirrus code from Wikibase
TASK DETAIL
EMAIL PREFERENCES
To: Smalyshev
Cc: gerritbot, Addshore, Aleksey_WMDE, thiemowmde, RazShuty, WMDE-leszek, Lydia_Pintscher, Aklapper, Smalyshev, ET4Eva, Nandana, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, _jensen, D3r1ck01, FloNight, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb
Cc: gerritbot, Addshore, Aleksey_WMDE, thiemowmde, RazShuty, WMDE-leszek, Lydia_Pintscher, Aklapper, Smalyshev, ET4Eva, Nandana, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, _jensen, D3r1ck01, FloNight, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
