daniel added a comment.

  > Change SlotRecord::hasSameContent to no longer take the size into account 
(given the other criteria checked in there, I guess this would be fine)
  
  Comparing the hash would be sufficient, but it's expensive if the hash isn't 
in the database (can't happen with the new schema, but the new schema isn't 
even the default yet). But doesn't the hash also depend on the php 
serialization?... Or is that based on the entity's json serialization for some 
reason?

TASK DETAIL
  https://phabricator.wikimedia.org/T220904

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo, daniel
Cc: Addshore, daniel, Michael, Ladsgroup, Lucas_Werkmeister_WMDE, 
matej_suchanek, Lydia_Pintscher, Edoderoo, Bencemac, Aklapper, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to