hoo added a comment.
In T220904#5140840 <https://phabricator.wikimedia.org/T220904#5140840>, @daniel wrote: > > Change SlotRecord::hasSameContent to no longer take the size into account (given the other criteria checked in there, I guess this would be fine) > > Comparing the hash would be sufficient, but it's expensive if the hash isn't in the database (can't happen with the new schema, but the new schema isn't even the default yet). But doesn't the hash also depend on the php serialization?... Or is that based on the entity's json serialization for some reason? That is based on the JSON it seems (at least it seems to be stable even when the size, thus the serialization) changes) In T220904#5140852 <https://phabricator.wikimedia.org/T220904#5140852>, @Lucas_Werkmeister_WMDE wrote: > 3. Stop using `serialize` in `EntityContent::getSize()` and instead use e. g. `json_encode()`? (Though that only fixes the problem going forward, and might make the problem much worse when comparing against entities whose size was still computed using `serialize`?) Yes, we should definitely do that… but unless we back propagate it (yikes!), this wont solve this particular problem. TASK DETAIL https://phabricator.wikimedia.org/T220904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Addshore, daniel, Michael, Ladsgroup, Lucas_Werkmeister_WMDE, matej_suchanek, Lydia_Pintscher, Edoderoo, Bencemac, Aklapper, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
