NavinoEvans added a comment.

  @WMDE-leszek Thanks so much for taking a look at this! 
  Yes, the issue you describe on step 8 in your example is the main problem to 
solve. To me the root of the issue is that the user is allowed to skip through 
steps //without// having actually completed the instructions. This means that 
the popup is trying to attach to an element that **is not visible** on the page.
  
  For this main issue, it seems that the only options are to either:
  
  1. Complete each step for the user automatically if they have not done so 
themselves. This will insure that the relevant elements are visible at each 
step.
  
  OR
  
  2. Prevent the user from skipping to the next step until they have completed 
the current step (e.g. by disabling the next button)
  
  Fixing with method 2 seems a lot simpler, albeit not as nice for the end user.
  
  ---
  
  I would also note that there is another issue that has been identified as a 
'race condition'. This is what some of the previous fixes posted earlier in the 
thread are addressing.
  In this case, the element to attach to is visible but the somehow the popup 
is not still not attached. These are obviously connected but not the same 
problem. I have not experienced this second issue myself but others have 
reported it. I will do some further testing on this and post an example 
tomorrow with steps to reproduce.
  
  Hopefully that makes sense, fire away with any further questions or things 
you's like us to test and report back on.
  
  Many thanks!

TASK DETAIL
  https://phabricator.wikimedia.org/T213704

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: NavinoEvans
Cc: WMDE-leszek, thiemowmde, Jakob_WMDE, MartinPoulter, Ladsgroup, Addshore, 
Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, 
Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to