NavinoEvans added a comment.
Just to confirm from my previous message after some further testing, there are in fact two separate issues: Bug 1 - User can reach a step where the tour popup needs to attach to an element which is not visible ----------------------------------------------------------------------------------------------------- If you use **only the "next" arrow** to get to the next tour window, then you can reach later steps without having actually completed the task in each instruction window. If the skipped task was needed in order to show an element on screen for the next step, then the instruction window will default to the middle of the screen as the element it needs to attach to is not visible Steps to reproduce: 1. Load this tour - https://test.wikidata.org/w/index.php?title=Q1027&tour=wbqualifiers&data=ok 2. On Step 6 "Add Qualifiers", do **not** complete the instruction to click on the "edit" button. Instead just click the "next" arrow. 3. On step 7, you can see that the tour popup is just in the centre of the screen. It is trying to attach to the "Add qualifier" button, but this is not visible because the "edit" section was not been opened in Step 6. Bug 2 - Race between DOM loading and tour popup trying to attach to it ---------------------------------------------------------------------- This only happens in two situations: 1. If the very first step in the tour has an attached popup ----------------------------------------------------------- The page may not have been fully loaded when the Step 1 popup tries to attach to an element. You can see an example of this when you load this test tour - https://test.wikidata.org/w/index.php?title=Q1027&tour=wbtest&data=ok For me, the popup is not attached the **first time** the page loads (i.e. before it's cached). On subsequent reloads it works fine, but happens once again after I clear my cache 2. The user triggers the next step by clicking on a button which **shows a new part of the page** ------------------------------------------------------------------------------------------------- This can happen in all the same situations as Bug 1 above, but by //completing// the instruction instead of skipping it with "next" arrow. So, whenever the user **gets to the next step by performing an action that will show/create elements** on the page, the next popup attachment needs to race with the DOM being updated (next popup is trying to attach to DOM elements that are being rendered simultaneously) I can't repeat this issue reliably on any particular tour. Examples can be found in any tour steps that ask you to perform an action which shows new elements like "click 'edit' button", "click 'add qualifier' button", "click add labels". See Step 7 in this tour https://www.wikidata.org/w/index.php?title=Q16943273&tour=wbitems&data=ok TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: NavinoEvans Cc: WMDE-leszek, thiemowmde, Jakob_WMDE, MartinPoulter, Ladsgroup, Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
