Daimona added a comment.
In T226244#5273853 <https://phabricator.wikimedia.org/T226244#5273853>, @alaa_wmde wrote: > In T226244#5273849 <https://phabricator.wikimedia.org/T226244#5273849>, @gerritbot wrote: > > > Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy): > > [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup config > > > > https://gerrit.wikimedia.org/r/518256 > > > @Daimona think you are trying to achieve the same effect I did with https://gerrit.wikimedia.org/r/518249 (https://phabricator.wikimedia.org/T226244#5273778). > > Though I wouldn't add an explicit dependency here on Wikibase phan config. Lexeme and Wikibase can have different configurations in the long run. What do you think? @alaa_wmde Actually, not really. With the phan dependency in composer, we can use the standard MediaWiki config (source <https://github.com/wikimedia/mediawiki-tools-phan>), which is what all extensions should do. For some reason, Wikibase redeclares its own config, so that it'll inevitably drift from the default. My change introduces a dependency on the standard config, not the Wikibase one, so this is the right way to go :-) I also tried to *remove* all suppressions to see what's really left to fix. The first thing I noticed is that all "A inherits B which is declared at X and also at Y" warnings have gone, and that was due to misconfiguration including Wikibase twice, probably. Now it complains about some methods not being declared (instead of being declared twice, eheh), but that's probably something we can fix via config. You'll also notice many warnings like "...can usually be simplified to...". They come from a phan plugin which is included in the standard config, but not in Wikibase - that's what I meant with "it'll inevitably drift from the default". At this point, I'd like to fix all issues reported for my patch, but that could take some time. And at the end, the same config change will have to be applied to Wikibase itself. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
