Daimona added a comment.
In T226244#5273866 <https://phabricator.wikimedia.org/T226244#5273866>, @alaa_wmde wrote: > @Daimona understood. I also think the clean-up work is necessary. I'm not such a fan of statements of the sort "extensions must use mediawiki config rather than overriding/changing them" but that's a separate topic anyway. Ah, I haven't been clear. Extensions *should* override the default config, e.g. to define additional dependencies (many extensions do that). But it's vital that the default config is first included, then overridden for the necessary part. What happened for Lexeme (and WB itself) is that the default config has just been copypasted. And you'll probably agree that copypastas are always very bad for maintainability in the long term. > I would actually like to merge my patch first to fix the build first.. your patch can then rebase on it. Is that fine by you? Definitely, I implicitly meant that. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
