thcipriani added a comment.
In T227814#5327808 <https://phabricator.wikimedia.org/T227814#5327808>, @Lucas_Werkmeister_WMDE wrote: > So did we figure out what happened? (The change @thcipriani linked is by me, and I also think it feels suspect, so I hope this is not my fault 😬) > Edit: And if this was only fixed by reverting the train, and the issue persists on Test Wikidata, shouldn’t the task remain open? 1.34.0-wmf.13 is on all wikis, this was fixed by re-running `scap sync`. I'm not exactly happy about that outcome since I don't understand how it failed the first go-round. I looked closely at `mergeMessageFileList.php` today (which is the file that generates ExtensionsMessages-[version].php) and I'm not clear on how it works at all. Essentially what `mergeMessageFileList.php` seems to do is do a `require_once` for all php files in `extension-list` (pre-seeding the `$wgExtensionMessagesFiles` and `$wgMessagesDirs` variables), then it extracts the global variables `wgExtensionMessagesFiles` and `wgMessagesDirs` from any json file in `extension-list`; however, when a file you've `require`d adds a `json` file to the ExtensionRegistration queue (as in the Wikibase patch) when is that queue processed? I don't know, but it seemingly does (at least most of the time). TASK DETAIL https://phabricator.wikimedia.org/T227814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: greg, thcipriani Cc: Michael, Lucas_Werkmeister_WMDE, Lea_Lacroix_WMDE, greg, Agusbou2015, Tacsipacsi, Liuxinyu970226, thcipriani, Krinkle, Jdforrester-WMF, Aklapper, Mormegil, darthmon_wmde, Nandana, Imarlier, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
