Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE added a comment.
In T227814#5329364 <https://phabricator.wikimedia.org/T227814#5329364>, @thcipriani wrote: > Looking at https://www.mediawiki.org/wiki/Manual:Extension_registration#Migration_for_extension_developers it looks like you should keep `$wgMessagesDirs` specifically for `mergeMessageFileList` (see the comment in the example code on that page) > > <?php > if ( function_exists( 'wfLoadExtension' ) ) { > wfLoadExtension( 'FooBar' ); > // Keep i18n globals so mergeMessageFileList.php doesn't break > $wgMessagesDirs['FooBar'] = __DIR__ . '/i18n'; I asked about that on the talk page <https://www.mediawiki.org/wiki/Topic:V011ml6cu7w5yhae> and the conclusion was that this is only necessary for `extension-list` entries, so removing the i18n globals in the WikibaseLib entry point should have been fine. If `mergeMessageFileList.php` does a `require_once` of the WikibaseRepo or -Client entry points, then it would also end up with the WikibaseLib entry point, and perhaps in that case we would need to keep the i18n globals after all… but it seems like, at least sometimes, having them only in the JSON file works? No idea why, though. I think we should try to finish the Wikibase move to extension registration soon, and we’re actively working on it, but until we’re done with that perhaps it’s better to add the i18n globals back to the PHP entry points just to be sure? Anyways, closing this task again since it seems like it’s still fixed, broken pages just need to be purged. TASK DETAIL https://phabricator.wikimedia.org/T227814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: greg, Lucas_Werkmeister_WMDE Cc: Premeditated, Michael, Lucas_Werkmeister_WMDE, Lea_Lacroix_WMDE, greg, Agusbou2015, Tacsipacsi, Liuxinyu970226, thcipriani, Krinkle, Jdforrester-WMF, Aklapper, Mormegil, darthmon_wmde, Nandana, Imarlier, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
