Jakob_WMDE added a comment.
Apologies for popping in unsolicited, but it looks like this task and its patches took a strange turn. The original idea was to start sharing the component with Termbox (says so in the title/description), which I think is great. Then, based on the `a` tag vs `button` tag difference the idea of reuse was quickly discarded. Arguably slightly different requirements, fine. Now there are patches up copying the Termbox component into the Bridge code base, changing it so that it fulfills requirements from both Termbox and Bridge (afaict), then further improving it. What's the point? There are two options that make sense to me: a) Don't use the Termbox component, have a Bridge button component that strictly does what's needed for Bridge or b) Reuse and share the component between the code bases as planned when this task was written. What's there at the moment looks like a lose-lose situation: unused code from Termbox in Bridge, double the maintenance, Termbox not benefiting from the improvements. TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Jakob_WMDE Cc: Jakob_WMDE, Michael, Aklapper, Pablo-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
