Pablo-WMDE added a comment.
Talked with @Hanna_Petruschat_WMDE ragarding "bullet 3", i.e. the reasoning back when during termbox. She confirmed that the "primaryprogressive" button implemented for termbox is indeed supposed to follow the OOUI specification and all discrepancies can be considered unintended (and consequently bugs to some extend). Hanna however was kind enough to point a key difference between the "primaryprogressive" button as used in termbox and the one we can observe in the bride spec and the related OOUI demo for "process dialog": the "primaryprogressive" itself exhibits rounded corners (`border-radius: 2px`) but these are removed <https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/src/themes/wikimediaui/windows.less;06af8554a827416bfba64974ca63a86bfe30fa6c$148> from the element when used as a part of a header ("processDialog actionWidget" in OOUI terminology) as intended in bridge. We now have clarity on the requirements' side but face a bit of a technological challenge. OOUI implements this by implementing a selector specific to this case (button inside dialog). For our vue components we, so far, followed the BEM approach <https://gerrit.wikimedia.org/r/plugins/gitiles/wikibase/termbox/+/f3ad6c7606e09524bc9e8b8f60364655743f235e/docs/styles.md> and the component's appearance are organized in so-called modifications ("primaryprogressive" is an example of this) and we usually refrain from influencing these modifications' styles from the outside but rather create a new component modification. So how do we tackle this? TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Hanna_Petruschat_WMDE, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Charlie_WMDE, Jakob_WMDE, Michael, Aklapper, Pablo-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
