Addshore added a comment. So:
- Per https://github.com/DataValues/Time/blob/master/src/DataValues/TimeValue.php#L34 the year should apparently have 11 digits - Per https://github.com/DataValues/Time/blob/master/src/DataValues/TimeValue.php#L95 the year is allowed between 1 and 16 digits - Per https://github.com/DataValues/Time/blob/master/src/ValueParsers/TimeParser.php#L91 parsed times will be padded and always have 16 digits Thus: - The documentation in the comments at the top of TimeValue should be fixed as it is incorrect! ( https://github.com/DataValues/Time/issues/28 ) - Old information and old revisions in the database can not be changed and should not be changed. - The number of zeros in a year for an item can be changed buy fixing that claim and making a new revision of the item. - The constructor for TimeValue needs to continue to allow many different lengths of year due to legacy data, we need to stay backwards compatible. All new dates added through the UI should be 8601 compliant with 16 digits in the year We need to again check the API and see what can be manually added, I suspect a year of any length can be added :/ TASK DETAIL https://phabricator.wikimedia.org/T66084 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Jc3s5h, Wikidata-bugs, Nemo_bis, Addshore, MZMcBride, Lydia_Pintscher, JohnLewis, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
