Michael added subscribers: Tonina_Zhelyazkova_WMDE, Pablo-WMDE, 
Lucas_Werkmeister_WMDE, Michael.
Michael added a comment.


  Yes, the intention of the ticket makes sense to me.
  
  @Pablo-WMDE @Lucas_Werkmeister_WMDE @Tonina_Zhelyazkova_WMDE :
  From a technical point of view, there are some interesting technical 
challenges here when we try to integrate this change into Bridge.
  
  While thinking about it more, I feel a component in a library should probably 
use `em` instead of `rem` in order to respect the styles of the components that 
wrap it. So maybe we should change that.
  But then, there is a `font-size: 0.875em` on `body > .oo-ui-windowManager` 
that is around the entire data bridge app. So an `font-size: 1em;` in this 
radio-button would currently result in a rendered size of `14px` instead of the 
expected `16px`.
  
  How do we deal with that? We could add a `font-size: calc(1em/0.875);` on 
`#data-bridge-app`?
  
  (Note on process: I don't think this ticket needs an urgent fix, but rather 
we can use it to ponder how we would like to to handle `font-size` and what 
depends on it in Bridge in general.)

TASK DETAIL
  https://phabricator.wikimedia.org/T243192

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Pablo-WMDE, Tonina_Zhelyazkova_WMDE, 
Aklapper, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to