Michael added a comment.

  In T243192#5816612 <https://phabricator.wikimedia.org/T243192#5816612>, 
@Michael wrote:
  
  > While thinking about it more, I feel a component in a library should 
probably use `em` instead of `rem` in order to respect the styles of the 
components that wrap it. So maybe we should change that.
  > But then, there is a `font-size: 0.875em` on `body > .oo-ui-windowManager` 
that is around the entire data bridge app. So an `font-size: 1em;` in this 
radio-button would currently result in a rendered size of `14px` instead of the 
expected `16px`.
  > How do we deal with that? We could add a `font-size: calc(1em/0.875);` on 
`#data-bridge-app`?
  
  I just noticed that "`font-size: 0.875em` on `body > .oo-ui-windowManager`" 
is only true on the default Desktop skin, not on Minerva. So maybe our fix 
should rather be `font-size: 1rem;` on `#data-bridge-app`?

TASK DETAIL
  https://phabricator.wikimedia.org/T243192

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Charlie_WMDE, Michael, Lucas_Werkmeister_WMDE, Pablo-WMDE, 
Tonina_Zhelyazkova_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to