Michael added a comment.
In T249120#6022064 <https://phabricator.wikimedia.org/T249120#6022064>, @Lucas_Werkmeister_WMDE wrote: > I looked a bit more into the possible error types we have which don’t have more specific handlers, and I think they are: > > - `INVALID_ENTITY_STATE_ERROR` (`validateEntityState` action: entity has no statements for property) > - `UNSUPPORTED_DATAVALUE_TYPE` (`validateBridgeApplicability` action: data type is string but data value type isn’t) > - `SAVING_FAILED` (`saveBridge` action: `entitySave` failed) > - `APPLICATION_LOGIC_ERROR` (`initBridge` action: any part of init failed; `setTargetValue` or `saveBridge` actions: called in wrong state; `saveBridge` action: statement mutation failed) > > I think the `.type` of each error is the “error code” we can use to bucket the error. No, that is not the intention (at least not the one I had during story writing). This would be way too coarse. I think we should use the message of the actual `Error` object we are throwing, e.g. `'Entity flagged missing in response.'`. _That_ is what I want to see in Grafana. The big error categories can maybe be part of the string that is then logged, like `INVALID_ENTITY_STATE_ERROR.Entity flagged missing in response.` But the message that we log should be unique to the place where we throw the exception. TASK DETAIL https://phabricator.wikimedia.org/T249120 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Michael Cc: Michael, Lucas_Werkmeister_WMDE, Aklapper, Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
