Lucas_Werkmeister_WMDE added a comment.

  Well, I think the changes I uploaded do provide a way forward in that 
direction: where we need to //track// more specific information, split out an 
additional error `.type`. (In fact, the first change already does this, 
splitting `INITIALIZATION_ERROR` out of `ErrorTypes.APPLICATION_LOGIC_ERROR`.) 
Some of the existing error types are already highly specific: both 
`INVALID_ENTITY_STATE_ERROR` and `UNSUPPORTED_DATAVALUE_TYPE` are thrown in 
exactly one location each, so if we see them pop up, we know what happened 
(though not necessarily //why// it happened). `SAVING_FAILED`, on the other 
hand, is currently rather generic, and I expect we’ll refine it as part of 
T248087: Step 1: Improved generic error screen: on save (impact: high) 
<https://phabricator.wikimedia.org/T248087>.
  
  I also wonder if we shouldn’t maybe track all the error types in Graphite, 
not just the ones that end up in `ErrorUnknown` but also the ones that have 
other handlers, including the bailouts. Then this could happen as part of the 
`addError` action or the `addApplicationErrors` mutation.

TASK DETAIL
  https://phabricator.wikimedia.org/T249120

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Aklapper, Pablo-WMDE, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to