[Wikidata-bugs] [Maniphest] [Created] T253064: Declaration of function onLoginFormValidErrorMessages($messages) : void should be compatible with function onLoginFormValidErrorMessages(array $messages)

[Reedy]

Reedy created this task.
Reedy added projects: MediaWiki-extensions-WikibaseClient, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  21:10:54 <checkstyle version="6.5">
  21:10:54   <file 
name="client/includes/Hooks/LoginFormValidErrorMessagesHandler.php">
  21:10:54     <error line="13" severity="warning" message="Declaration of 
function onLoginFormValidErrorMessages(&amp;amp;$messages) : void should be 
compatible with function onLoginFormValidErrorMessages(array 
&amp;amp;$messages) (parameter #1 with no type cannot replace original 
parameter with type 'array') defined in 
../../includes/specials/Hook/LoginFormValidErrorMessagesHook.php:22" 
source="PhanParamSignatureRealMismatchHasNoParamType"/>
  21:10:54   </file>
  21:10:54 </checkstyle>
  
  Seemingly broken by rMW29d91c2c5716: Typehint onLoginFormValidErrorMessages 
param as array 
<https://phabricator.wikimedia.org/rMW29d91c2c571652439b5d4e26b70b00519082523a> 
by @Lucas_Werkmeister_WMDE

TASK DETAIL
  https://phabricator.wikimedia.org/T253064

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Reedy, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, lucamauri, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs