Lucas_Werkmeister_WMDE added a comment.
Ugh. Quoting myself from the commit message: > This is a compatible change for implementors, since implementing classes > are allowed to widen the parameter type from “array” to “mixed”. I tested that PHP itself allows this, but it never occurred to me to check whether Phan allowed this or not. Sorry for the breakage :( (So what //is// the correct way to upgrade an interface to use type hints if it has implementations in a different repository? Adding the type hint to the implementation first isn’t allowed by PHP because it violates LSP <https://www.wikidata.org/wiki/Special:GoToLinkedPage/enwiki/Q957386>, but adding it to the interface first is apparently disallowed by Phan… I guess you upload changes for MediaWiki and all other repositories together, with Depends-On pointing from the other changes to the MediaWiki change, get the other changes +2ed first, and then merge the MediaWiki change, so that it all gets merged more or less at the same time?) TASK DETAIL https://phabricator.wikimedia.org/T253064 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy, Lucas_Werkmeister_WMDE Cc: Reedy, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
