Reedy added a comment.
In T254675#6274431 <https://phabricator.wikimedia.org/T254675#6274431>, @Peter.ovchyn wrote: > @Jdlrobson I renamed opt name and inverted logic accordingly. Is there any instruction on how to change mediawiki-config ? So with how your patch current is, it's pretty difficult. In Wikimedia production, we generally support two different versions of MW at once, for most of a week. So when you explicitly rename things, without leaving the old version, it's potentially hard to migrate. Depending on how it's used For migrationary purposes (of config vars, at least. Though, you could argue there should be the same for function renames as per the deprecation policy), it's easier to add the new one, make it have prescedence in the code, wait for the new code to be deployed everwhere and stable, update medawiki-config, and then remove the old variable at some point later. However, looking at the usage in mediawiki-config, it's a no-op and the same as default, currently: 'wgWPBSkinBlacklist' => [ 'default' => [], ], So that should really just be removed from InitialiseSettings.php, as it serves no value. However, your inverting the logic, which then means we've presumably go to list all the skins. Does that really make sense? You can contribute patches to the operations/mediawiki-config like any other repo. Deployment just requires being included in Backport windows <https://wikitech.wikimedia.org/wiki/Backport_windows> TASK DETAIL https://phabricator.wikimedia.org/T254675 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter.ovchyn, Reedy Cc: Reedy, Aklapper, abi_, Amire80, Ladsgroup, Dinoguy1000, APerson, Isarra, MZMcBride, Krenair, Anomie, bd808, jeblad, Majavah, Izno, Peachey88, Jdlrobson, sgrabarczuk, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, holger.knust, joker88john, CucyNoiD, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, Af420, Bsandipan, Winter, Lewizho99, Maathavan, Wikidata-bugs, Lydia_Pintscher, siebrand, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
