Ammarpad added a comment.

  Yes, the issue started here. The task description inverted the logic.
  
  > Rename WPBSkinBlacklist to WPBSkinEnabled
  > Rename isSkinBlacklisted to isSkinEnabled
  
  You should however retain the logic in the patch. That's isSkinDisabled() for 
the method and WPBSkinDisabled for the config variable.

TASK DETAIL
  https://phabricator.wikimedia.org/T254675

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter.ovchyn, Ammarpad
Cc: Ammarpad, Reedy, Aklapper, abi_, Amire80, Ladsgroup, Dinoguy1000, APerson, 
Isarra, MZMcBride, Krenair, Anomie, bd808, jeblad, Majavah, Izno, Peachey88, 
Jdlrobson, sgrabarczuk, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
holger.knust, joker88john, CucyNoiD, Gaboe420, Amorymeltzer, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Winter, Lewizho99, Maathavan, Wikidata-bugs, 
Lydia_Pintscher, siebrand, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to