Ladsgroup added a comment.

  So I changed everything to Persian and even uploaded it as a POC PR: 
https://github.com/wmde/query-builder/pull/64
  
  Here's is my observations (they are not necessarily all RTL issues):
  F33917654: image.png <https://phabricator.wikimedia.org/F33917654>
  F33917656: image.png <https://phabricator.wikimedia.org/F33917656>
  F33917658: image.png <https://phabricator.wikimedia.org/F33917658>
  Mostly it looks good but:
  
  - The fallback result when there's no label in Persian is RTL but it should 
be LTR
  - The result iframe is all in English and LTR, fixing it wouldn't be easy, I 
don't think we can use non-ASCII characters for variable names.
  - RTL support is a continuous work in progress, while currently the RTL 
issues are minor, I think we don't keep tap on them and with the query builder 
getting more complex, we will end up with really large issues at hand.
  - The font of the title is terrible for Persian, it's so bad for Persian that 
it's hurting my eyes :( If I understood the dev tool correctly, it's "Linux 
Libertine"

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to