Michael added a comment.
In T267733#6627887 <https://phabricator.wikimedia.org/T267733#6627887>, @Ladsgroup wrote: > Mostly it looks good but: > > - The fallback result when there's no label in Persian is RTL but it should be LTR Fixing that might be tricky. We could wrap all things we language in them in `<bdi>`, Otherwise, we may have to do it on a per-case basis which would require us getting that info from vue-banana-i18n? > - The result iframe is all in English and LTR, fixing it wouldn't be easy, I don't think we can use non-ASCII characters for variable names. Could you explain a bit more? Which variable names are you thinking about? > - RTL support is a continuous work in progress, while currently the RTL issues are minor, I think we don't keep tap on them and with the query builder getting more complex, we will end up with really large issues at hand. 👍 > - The font of the title is terrible for Persian, it's so bad for Persian that it's hurting my eyes :( If I understood the dev tool correctly, it's "Linux Libertine" That is fortunately easy to change. But let's look at it again when one can actually view the Query Builder in Persian TASK DETAIL https://phabricator.wikimedia.org/T267733 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Michael Cc: Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
