Lucas_Werkmeister_WMDE added a comment.
I’m still confused where these IDs come from. I thought it might be from
`LinksDeletionUpdate`, which is a subclass of `LinksUpdate` and probably runs
the same hook, but the stack trace shows that’s not the case:
#4
/srv/mediawiki/php-1.36.0-wmf.21/extensions/Wikibase/client/includes/Hooks/DataUpdateHookHandler.php(124):
Wikibase\Client\Hooks\DataUpdateHookHandler->doLinksUpdateComplete(LinksUpdate)
#5
/srv/mediawiki/php-1.36.0-wmf.21/includes/HookContainer/HookContainer.php(163):
Wikibase\Client\Hooks\DataUpdateHookHandler->onLinksUpdateComplete(LinksUpdate,
integer)
These methods are being called with an instance of `LinksUpdate`, not
`LinksDeletionUpdate`, unless I’m misunderstanding how PHP formats stack traces.
However, while looking through the `LinksUpdate`/`LinksDeletionUpdate` code,
I noticed the (parent) class has an `mId` member, which I guess we want to use
instead of `->getTitle()->getArticleId()` – the `mId` looks like it’s more
stable. (There’s no getter for `mId`, but the field itself is public, and the
stable interface policy
<https://www.mediawiki.org/wiki/Stable_interface_policy> says it’s stable to
access public class fields.)
TASK DETAIL
https://phabricator.wikimedia.org/T264929
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz,
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331,
Rxy, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
