Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. Lucas_Werkmeister_WMDE added a comment.
If that’s true (Noa thought it sounded sensible), then the only thing left to do would be to remove some of the logging we added here. (You can find the log messages by searching for `T264929` in the source code.) - The “info” message in `DataUpdateHookHandler` I would keep, since it doesn’t hurt and (due to the low level) doesn’t clutter logstash either, even if it starts happening again. - I’m less sure about the “warning” message in `EntityUsageTable`. I’m tempted to turn that case back into an exception, like it was at the beginning of this task. But maybe that’s not a good idea? After all, in both cases, there’s a sensible “default” action (when writing entity usages: produce empty array of usage rows for page ID 0; when reading entity usages: skip rows with page ID 0), and warnings already go to logstash – do we gain anything from turning the warning into an error? I guess uncaught errors are still more visible than warnings in logstash, but is that worth the cost of aborting the current request / job? Thoughts? TASK DETAIL https://phabricator.wikimedia.org/T264929 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
