Charlie_WMDE added subscribers: Lydia_Pintscher, Charlie_WMDE. Charlie_WMDE added a comment.
@Michael The main thing I noticed and that we also already talked about is - how the line break moves down one component at first, before moving a second one - in the stacked view (starting with layout 3), the first dropdown component has a too big margin to the lookup component above - in stacked view (layout 4), somewhere around a 385px width viewport, the padding/margins between the components and the decorator/page start to be wrong. the components stop shrinking (they can have a min width of 256) instead of the margins/padding shrinking which results in the components extruding beyond the decorator - the components only switch to L components at a 320px width viewport. this is still an open question but the desired result would be for the components to switch to L components when all components stack (layout Nr.4) - not exactly related to this ticket i think (?) but starting with layout 3 the lookup component does not fit into the viewport anymore. Desired behavior can be seen in this slide deck <https://docs.google.com/presentation/d/1GB9WcQDQDYaf_kr0RvuaAuadKLPRytdcZ1vL78N2vx0/edit#slide=id.ga87d6e42ef_0_21> (WIP) The other things i'm going to mention were missing or wrong from the specs but have been added/changed now. As discussed with @Lydia_Pintscher we agreed to add them to this ticket instead of making a new one. - decorator styles for color and border - spacing between element above (find all items ...) and element below (add condition button) - spacing between conditions* TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Charlie_WMDE Cc: Charlie_WMDE, Lydia_Pintscher, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
