Charlie_WMDE added a comment.
Hello! o/ love the progress it looks so cool! <3 Here are a few things i noticed: - only for layout 3 - i am failing to inspect the margin between the stacked components. visually it seems to me though, like the first dropdown component still has a too big margin to the lookup component above. That being said, now that i'm able to compare it to the "correct" margin in layout 4, i actually prefer the way it is in layout 3, which technically has the "wrong" margin. could we change layout 4 to have the same margin as layout 3? Really sorry about that. it didn't look that "off" in my designs - i also noticed that the switch from 3 --> 4 seems to happen a bit too late. the delete-button manages to get too close to the lookup component. it seems like the left margin of 24px doesn't get respected anymore F34000591: image.png <https://phabricator.wikimedia.org/F34000591> For documentation's sake: Things that are still missing but are in the DS backlog - making the M->L component breakpoint 720px - fixing the responsiveness of the lookup component menu Things that we agreed not to do (for now at least): - forcing a 2x2 line break instead of moving down one component at first, before moving a second one TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Ladsgroup, Charlie_WMDE, Lydia_Pintscher, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
