Lucas_Werkmeister_WMDE added subscribers: Vlad.shapik, Peter.ovchyn. Lucas_Werkmeister_WMDE added a comment.
I’m confused by what happened in RevisionRecord: make RevisionRecord::getId() take a wiki ID <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/658312>. It seems to have added an optional parameter to the `getId()` method, but then also immediately hard deprecated calling `getId()` without that optional parameter: `getId()` calls `wfDeprecatedMsg()` if the `$wikiId` parameter (defaults to `self::LOCAL`) is not the same as `$this->getWikiId()`, so for a `RevisionRecord` belonging to a non-local wiki, calling `getId()` without arguments will now trigger a call to `wfDeprecatedMsg()`. But `wfDeprecatedMsg()` is apparently enough to make unit tests fail, and also cause warnings to be displayed in the page output, so I assume it counts as hard deprecation. Shouldn’t there have been a period of soft deprecation in between? CCing some of the people who worked on T272485: Make RevisionRecord::getId() take a wiki ID <https://phabricator.wikimedia.org/T272485> and also marking this as a train blocker until this is cleared up a bit more. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Peter.ovchyn, Vlad.shapik, Lucas_Werkmeister_WMDE, Pchelolo, daniel, Addshore, toan, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
