Lucas_Werkmeister_WMDE added a comment.
> I was able to make the tests pass locally by applying a patch like this <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/661114> but I suspect there may be many more cases where this could occur as RevisionRecord::getId is called all over the place. I think that class (`WikiPageEntityDataLoader`) might be the only affected caller. There are other callers, but all the ones I found so far are in Repo and presumably only deal with local revisions: $ git grep -P '[rR]ev(?:ision)?(?:Record)?->getId\(\)' lib/includes/Store/Sql/WikiPageEntityDataLoader.php: $revision->getId(), lib/includes/Store/Sql/WikiPageEntityDataLoader.php: 'The serialized data of revision ' . $revision->getId() repo/includes/Actions/EditEntityAction.php: if ( $olderRevision->getId() == $newerRevision->getId() ) { repo/includes/Actions/EditEntityAction.php: return Status::newFatal( 'wikibase-undo-badpage', $this->getTitle(), $newerRevision->getId() ); repo/includes/Actions/EditEntityAction.php: return Status::newFatal( 'wikibase-undo-badpage', $this->getTitle(), $olderRevision->getId() ); repo/includes/Actions/EditEntityAction.php: return Status::newFatal( 'wikibase-undo-nocontent', $this->getTitle(), $olderRevision->getId() ); repo/includes/Actions/EditEntityAction.php: return Status::newFatal( 'wikibase-undo-nocontent', $this->getTitle(), $newerRevision->getId() ); repo/includes/Actions/EditEntityAction.php: return Status::newFatal( 'wikibase-undo-nocontent', $this->getTitle(), $latestRevision->getId() ); repo/includes/Actions/EditEntityAction.php: $olderRevision->getId(), repo/includes/Actions/EditEntityAction.php: $newerRevision->getId() repo/includes/Actions/EditEntityAction.php: if ( $newerRevision->getId() == $latestRevision->getId() ) { repo/includes/Actions/EditEntityAction.php: $this->showConfirmationForm( $newerRevision->getId() ); repo/includes/Actions/SubmitEntityAction.php: $summary->addAutoCommentArgs( $revision->getId(), $revUserText ); repo/includes/Diff/EntityContentDiffView.php: [ 'oldid' => $rev->getId() ] ); repo/includes/Diff/EntityContentDiffView.php: 'restore' => $rev->getId() repo/includes/Diff/EntityContentDiffView.php: $parserOutput = $page->getParserOutput( $parserOptions, $rev->getId() ); repo/includes/Hooks/ArticleRevisionVisibilitySetHookHandler.php: $revision->getId() repo/includes/Notifications/RepoEntityChange.php: 'revision_id' => $revision->getId(), repo/includes/Notifications/RepoEntityChange.php: 'rev_id' => $revision->getId(), repo/includes/RepoHooks.php: $revision->getId() repo/includes/RepoHooks.php: $revision->getId(), repo/includes/RepoHooks.php: && $wikiPage->getLatest() !== $revisionRecord->getId() repo/includes/RepoHooks.php: 'restore' => $revisionRecord->getId() repo/includes/Store/Sql/WikiPageEntityStore.php: $revision->getId(), repo/includes/Store/Sql/WikiPageEntityStore.php: $this->dispatcher->dispatch( 'redirectUpdated', $redirect, $revision->getId() ); repo/includes/Store/Sql/WikiPageEntityStore.php: return $revision->getId(); repo/tests/phpunit/includes/Actions/EditEntityActionTest.php: $params[ $key ] = $rev->getId(); TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Peter.ovchyn, Vlad.shapik, Lucas_Werkmeister_WMDE, Pchelolo, daniel, Addshore, toan, Aklapper, Akuckartz, WDoranWMF, holger.knust, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, AMooney
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
