Michael added a comment.
In T274283#6833303 <https://phabricator.wikimedia.org/T274283#6833303>, @Ladsgroup wrote: > In T274283#6833078 <https://phabricator.wikimedia.org/T274283#6833078>, @Charlie_WMDE wrote: > >> Improvement C: >> i forgot to leave specs for the placement of the checkboxes inside of the decorator. i added them now in the mobile mock for space reasons, but the same specs apply for desktop <https://www.figma.com/file/hZpaYX0xNNhK0L7kBvN6WK/Query-Builder?node-id=3168%3A2789> and they're all using the same token. let me know if this should be an extra ticket or can be done in this one > > Done: https://github.com/wmde/query-builder/pull/202 > >> Improvement E: >> >> - The buttons switch to full width a bit later than layout 4 is triggered > > Done: https://github.com/wmde/query-builder/pull/202 I'm not sure if this is intentional or not, but that change introduces another layout for a couple of pixels between layout 3 and layout 4. But it doesn't look bad. @Charlie_WMDE what do you think? F34107881: image.png <https://phabricator.wikimedia.org/F34107881> You can see it there: https://602bb7356bcc7715c49fa011--clicky-sparqly.netlify.app/ TASK DETAIL https://phabricator.wikimedia.org/T274283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Michael Cc: Michael, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
