Sarai-WMDE added subscribers: Charlie_WMDE, Sarai-WMDE.
Sarai-WMDE added a comment.
This looks good! After a first check I noticed a couple of things:
- It would be nice to fix the WiKit component and make the info icon/button
vertically centered with the QuantityInput label. In WiKit, this component is
using a different suffix for some reason (we should replace it there with the
right one), which didn't allow catching this detail before:
F34289766: Screenshot 2021-04-08 at 13.33.16.png
<https://phabricator.wikimedia.org/F34289766>
- I remember we talked about only displaying "real" units in the Quantity
lookup. How feasible is that? Would we want to document that as a future
improvement?
- Question for @Charlie_WMDE: would it make sense to simplify this error
message to something like "Please enter a number and select a valid unit
(optional)", I'd also suggest saying "leave empty" instead of "remove input"
(e.g. when an invalid unit is provided), which sounds a bit too jargon-y in my
opinion.
F34290474: Screenshot 2021-04-08 at 14.17.15.png
<https://phabricator.wikimedia.org/F34290474>
- I found this case where an item was wrongly excluded from the results after
the (right?) unit was specified. I thought this could be related to the fact
that the omitted item's quantity value has a qualifier (in comparison to the
items that kept being shown in the results), but trying other queries* refuted
that hypotheses, so now I'm not sure what might be wrong, if anything.
To reproduce: If you query for the property "speed" and just indicate a
matching value of "12", your results will retrieve – among others– the items
Q479726 <https://www.wikidata.org/wiki/Q479726> and Q88008887
<https://www.wikidata.org/wiki/Q88008887>. But the former item will not appear
if I specify the unit "knot" (I tried selecting various knot units just in
case) in my query. The only difference between these values is the use of
qualifiers, therefore the inference.
*A similar case where the value having a qualifier doesn't prevent the item
from appearting in the results: human painters that are 168 centimeters tall.
The fact that Takeshi Kitano is included in the list refutes the qualifier
hypothesis.
TASK DETAIL
https://phabricator.wikimedia.org/T268942
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, Charlie_WMDE, Michael, Aklapper, Lydia_Pintscher, Invadibot,
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
