Sarai-WMDE added a comment.
>> - It would be nice to fix the WiKit component and make the info icon/button vertically centered with the QuantityInput label. In WiKit, this component is using a different suffix for some reason (we should replace it there with the right one), which didn't allow catching this detail before: > > Could you create an new Ticket for that? It is something that we should fix, but it is somewhat detached from the functionality that is implemented here. Of course, I agree. Done <https://phabricator.wikimedia.org/T279666>. >> - I remember we talked about only displaying "real" units in the Quantity lookup. How feasible is that? Would we want to document that as a future improvement? > > I don't think that this is feasible and I also remember it different. In my memory we said we wanted explicitly allow all units, because: 1. that is what Wikidata does and 2. the world is complex. Afaik, it was a user that requested to only show real units. But I think @Lydia_Pintscher could confirm this either way. Sorry yes, I think I remember now that it was mentioned that there was no straightforward way to achieve this. > Yes, that is strange, but probably needs some dedicated investigation. E.g. are we sure the used the correct item "knot" for the speed? Because there are a couple of other items with the label "knot" and I'm not sure how to get to the Q-ID of the unit to check. I actually tried selecting different "knot" units. > Also, I just noticed that quantity queries are broken with "regardless of value" selected. Will fix after my "lunch" break. True! The query's not run at all. Guess that I didn't notice the results were not updated if the option is selected after runing the query. TASK DETAIL https://phabricator.wikimedia.org/T268942 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Sarai-WMDE, Charlie_WMDE, Michael, Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
