Michael added a comment.
In T285131#7162615 <https://phabricator.wikimedia.org/T285131#7162615>, @Lucas_Werkmeister_WMDE wrote: > On second thought, I’m not sure there’s anything to do here…? I thought earlier that T144248 <https://phabricator.wikimedia.org/T144248> was about a crash, but it’s just a logged warning – we already “provide something syntactically valid to the user”: > > curl -s 'https://www.wikidata.org/wiki/Special:EntityData/Q3629997.ttl?nocache=1536759432200&flavor=dump' | grep -A10 P625 > > > > wd:Q3629997 p:P625 s:Q3629997-469068A1-32BD-4D93-AF94-150EEC63BD2D . > > s:Q3629997-469068A1-32BD-4D93-AF94-150EEC63BD2D a wikibase:Statement, > wikibase:BestRank ; > wikibase:rank wikibase:NormalRank ; > prov:wasDerivedFrom ref:d5847b9b6032aa8b13dae3c2dfd9ed5d114d21b3 . > > wd:Q3629997 p:P646 s:Q3629997-757F941A-55D7-44DC-8568-2B92F4ECC16F . > > s:Q3629997-757F941A-55D7-44DC-8568-2B92F4ECC16F a wikibase:Statement, > wikibase:BestRank ; > > That is, we emit a statement node with rank and references, but no main snak at all, neither `ps:P625` nor `psv:P625` (or `wdt:P625`). > > I suppose the TTL proposed in the task description (attach some sort of error under `psv:P625`) could still be an improvement, but it hardly seems worth the effort. I agree. The naming issue is apparently unrelated. > So maybe the only thing left to do is to make the warning more quiet so it doesn’t pollute production logstash? (I think “notice” log level would be appropriate: “normal, but significant, condition”, above “info” but below “warning”.) Either that, or we could keep it an error and log it to the Wikibase channel. Because //if// it happens again, then we would surely want to know about it because that means we got invalid data into our DB again and need to do something about it. (Assuming the invalid data currently in the DB gets removed, as talked about elsewhere.) TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Michael Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
