Lucas_Werkmeister_WMDE added a comment.
Hmm, but if I wire this up with `SiteLinkUniquenessValidator` (as I had intended), then this will always be used to check all sitelinks of an item, not just added or modified sitelinks. And this would mean that, as long as an item has any sitelinks at all, a second edit to the item would only be possible after the first edit’s secondary data updates have finished. When the item has been edited, but the secondary updates haven’t been finished yet, then the keys for all the sitelinks will exist in memcached, and any other edits to the items will be detected as a conflict (because we’re not using the values for those keys, so we have no idea that it’s a “self-conflict”). Is this a problem? Is it usual for another edit to an item to start before the secondary updates have finished? And if it is a problem… do we need to go back to the version again where we write the item ID to the memcached key? TASK DETAIL https://phabricator.wikimedia.org/T291377 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, hoo, Lea_Lacroix_WMDE, Mohammed_Sadat_WMDE, Lydia_Pintscher, Addshore, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
