Daimona added a comment.
My opinion is that these classes should not be removed until we provide proper replacements. The task description already provides many useful examples, but there seems to be at least one use case which is not covered, i.e. when you want a (success|error|warning)box with some additional custom attributes. Currently, any such use case would need to hardcode the new class names. I'm arguing that this is tech debt and we shouldn't that in new code (and replacing the old class name with the new one effectively makes it "new" IMO). My proposal is that we either add some parameters to the `Html::*Box` functions to allow this customization, or we introduce new methods like `Html::getErrorBoxClasses()`. I believe that either solution can be implemented reasonably quickly and would still allow the April deadline to be met without introducing more technical debt. Additional context is available in the comments of r768144 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/768144>. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Krinkle, Edtadros, Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Fernandobacasegua34, Astuthiodit_1, 786, fenpedia, Suran38, Biggs657, karapayneWMDE, toberto, bwang, Invadibot, Feldpauschhaylee2017, LaMagiaaa, Lalamarie69, Zabe, Asartea, Florian_COLLIN, R4356th, Bebiezaza, maantietaja, Wilmanbeno, Juan90264, Alter-paule, Beast1978, CBogen, GeneralNotability, Un1tY, FelixE2019, Akuckartz, Dzaky17, Hook696, CptViraj, darthmon_wmde, ST47, WDoranWMF, Majavah, Kent7301, Chambersjay, RhinosF1, EvanProdromou, joker88john, SD0001, 94rain, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Tks4Fish, Tumzaaaa24, Gaboe420, Jony, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Minilexikon, Bsandipan, Gboyers, GoranSMilovanovic, ihojose, Mahir256, QZanden, LawExplorer, Litanwei, spatton, Samuele2002, Lewizho99, JJMC89, Maathavan, SundanceRaphael, _jensen, Jseddon, rosalieper, Agabi10, AGK, XanonymusX, Neuronton, RuyP, JEumerus, gabriel-wmde, Scott_WUaS, mb, Cirdan, Pchelolo, DStrine, XenoRyet, Wong128hk, Luke081515, Nirmos, Bsadowski1, mys_721tx, I_JethroBT, Unapersona, Zache, alex-mashin, Niharika, Wikidata-bugs, Snowolf, Base, aude, AndyRussG, Ebe123, Nullzero, Pcoombe, Huji, Dinoguy1000, jeblad, jayvdb, MrStradivarius, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, KartikMistry, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, Krenair, jeremyb, Legoktm
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
